[PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared()

Andy Shevchenko andy at kernel.org
Fri Aug 18 08:00:22 PDT 2023


On Fri, Aug 18, 2023 at 05:30:15PM +0800, Li Zetao wrote:
> Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for
> prepared and enabled clocks"), devm_clk_get() and clk_prepare() can now be
> replaced by devm_clk_get_prepared() when the driver enables (and possibly
> prepares) the clocks for the whole lifetime of the device. Moreover, it is
> no longer necessary to unprepare and disable the clocks explicitly.

The commit message isn't correct. Seems you copied'n'pasted from other cases.

Please, revisit.

Code wise looks legit to me.

With the commit message fixed
Reviewed-by: Andy Shevchenko <andy at kernel.org>

-- 
With Best Regards,
Andy Shevchenko





More information about the linux-arm-kernel mailing list