[PATCH -next 03/11] gpio: ftgpio010: Use helper function devm_clk_get_enabled()
Andy Shevchenko
andy at kernel.org
Fri Aug 18 06:47:25 PDT 2023
On Fri, Aug 18, 2023 at 05:30:10PM +0800, Li Zetao wrote:
> Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for
> prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable()
> can now be replaced by devm_clk_get_enabled() when the driver enables
> (and possibly prepares) the clocks for the whole lifetime of the device.
> Moreover, it is no longer necessary to unprepare and disable the clocks
> explicitly.
...
> - } else if (PTR_ERR(g->clk) == -EPROBE_DEFER) {
> + g->clk = devm_clk_get_enabled(dev, NULL);
> + if (PTR_ERR_OR_ZERO(g->clk) == -EPROBE_DEFER)
> /*
> * Percolate deferrals, for anything else,
> * just live without the clocking.
> */
> return PTR_ERR(g->clk);
> - }
It means you need to use _optional variant here and return whatever error you
get.
...
> platform_set_drvdata(pdev, g);
Do you now need this?
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list