[PATCH] arm64: dts: marvell: add DTS for 7215-IXS-A1 board

Andrew Lunn andrew at lunn.ch
Thu Aug 17 12:21:11 PDT 2023


On Thu, Aug 17, 2023 at 01:14:22PM -0400, Natarajan Subbiramani wrote:
> On Thu, Aug 17, 2023 at 12:07 PM Andrew Lunn <andrew at lunn.ch> wrote:
> >
> > > +&mdio {
> > > +     phy0: ethernet-phy at 0 {
> > > +             marvell,reg-init = <0x03 0x10 0x0 0x1140>;
> >
> > Please document what this is doing? I assume it is changing an LED?
> > But i'm too lazy to go look at the datasheet.
> >
> Yes, This is to configure the management port LED to turn ON/OFF on
> Link Up/Down state and BLINK on activity.

So there is new code merged recently to control the marvell LEDs from
userspace. Please take a look at
arch/arm/boot/dts/marvell/armada-370-rd.dts which defines an LED as
part of ethernet-phy at 0. The LED then appears in
/sys/class/leds/<foobar>/wan in this case, and you can configure it
for your use cases. I have a device tree binding in progress to be
able to specify the configuration, but that is not merged yet.
marvell,reg-init is a pretty horrible interface, so i would prefer not
to add any more users.

   Andrew



More information about the linux-arm-kernel mailing list