[PATCH v3 3/3] clk: imx: imx6sx: Remove hardcoded LCDIF1 parent

Fabio Estevam festevam at gmail.com
Tue Aug 15 05:49:27 PDT 2023


On Tue, Aug 15, 2023 at 9:34 AM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Abel,
>
> On Wed, Jul 12, 2023 at 8:53 AM Fabio Estevam <festevam at gmail.com> wrote:
> >
> > From: Fabio Estevam <festevam at denx.de>
> >
> > It is not a good idea to hardcode the LCDIF1 parent inside the
> > clock driver because some users may want to use a different clock
> > parent for LCDIF1. One of the reasons could be related to EMI tests.
> >
> > Remove the harcoded LCDIF1 parent as this is better described via
> > devicetree.
> >
> > Signed-off-by: Fabio Estevam <festevam at denx.de>
> > ---
> > Changes since v2:
> > - Rebased against 6.5-rc1.
>
> Shawn has already applied patches 1/3 and 2/3.
>
> Could this one go via your tree, please?

Actually, please discard this one. I missed adding the following
suggestion from Stephen:

"Do you need to check for the DT property and skip these clk_set_parent()
calls if they're present? How does this work if the DT isn't updated at
the same time?"

I will revisit this after 6.6-rc1 is out.

Thanks



More information about the linux-arm-kernel mailing list