[PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs

Andrew Lunn andrew at lunn.ch
Sun Aug 13 10:03:21 PDT 2023


Hi Daniel

> This requires syscon phandle 'mediatek,pio' present in parenting MDIO bus
> which should point to the syscon holding the boottrap register.

If i'm reading the code correct, if this property is missing, the PHY
will fail to probe? Since this was never a mandatory property, it
looks like this will break old DT blobs?

If there are LED properties, then it should be mandatory, otherwise it
should be optional. That way you keep backwards compatibility with old
blobs.

	Andrew



More information about the linux-arm-kernel mailing list