[PATCH net-next] net: phy: mediatek-ge-soc: support PHY LEDs

Andrew Lunn andrew at lunn.ch
Fri Aug 11 09:39:00 PDT 2023


> > +	/* Only now setup pinctrl to avoid bogus blinking */
> > +	pinctrl = devm_pinctrl_get_select(&phydev->mdio.dev, "gbe-led");
> 
> This function gets reference on phydev->mdio.dev, but there is no code
> to release it. It looks like a leak which will prevent module unload,
> but I don't have hardware now to prove it.

Since it is a devm_ function, it should get released when the device
is destroyed. Or am i missing something?

   Andrew



More information about the linux-arm-kernel mailing list