[PATCH -next] media: nxp: Remove redundant dev_err()

[Mirela Rabulea]

> -----Original Message-----
> From: Ruan Jinjie <ruanjinjie at huawei.com>
> Sent: Thursday, July 27, 2023 1:22 PM
> To: Mirela Rabulea <mirela.rabulea at nxp.com>; dl-linux-imx <linux-
> imx at nxp.com>; mchehab at kernel.org; shawnguo at kernel.org;
> s.hauer at pengutronix.de; kernel at pengutronix.de; festevam at gmail.com;
> laurent.pinchart at ideasonboard.com; linux-arm-kernel at lists.infradead.org;
> linux-media at vger.kernel.org; linux-kernel at vger.kernel.org
> Cc: ruanjinjie at huawei.com
> Subject: [PATCH -next] media: nxp: Remove redundant dev_err()
> 
> There is no need to call the dev_err() function directly to print a custom message
> when handling an error from platform_get_irq() function as it is going to display
> an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>

Hi,
We have been using "media: imx-jpeg:" in the subject.
Other than that,
Reviewed-by: Mirela Rabulea <mirela.rabulea at nxp.com>

Regards,
Mirela

> ---
>  drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c      | 1 -
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index 9512c0a61966..b7a720198ce5 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -2742,7 +2742,6 @@ static int mxc_jpeg_probe(struct platform_device
> *pdev)
>         dev_info(&pdev->dev, "choose slot %d\n", jpeg->slot_data.slot);
>         dec_irq = platform_get_irq(pdev, 0);
>         if (dec_irq < 0) {
> -               dev_err(&pdev->dev, "Failed to get irq %d\n", dec_irq);
>                 ret = dec_irq;
>                 goto err_irq;
>         }
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> index c4454aa1cb34..65d20e9bae69 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> @@ -791,7 +791,6 @@ int mxc_isi_pipe_init(struct mxc_isi_dev *isi, unsigned
> int id)
> 
>         irq = platform_get_irq(to_platform_device(isi->dev), id);
>         if (irq < 0) {
> -               dev_err(pipe->isi->dev, "Failed to get IRQ (%d)\n", irq);
>                 ret = irq;
>                 goto error;
>         }
> --
> 2.34.1