[PATCH 2/2] pinctrl: nsp-gpio: Silence probe deferral messages

Florian Fainelli florian.fainelli at broadcom.com
Mon Aug 7 14:30:22 PDT 2023


We can have gpiochip_add_data() return -EPROBE_DEFER which will make
us produce the "unable to add GPIO chip" message which is confusing.
Use dev_err_probe() to silence probe deferral messages.

Signed-off-by: Florian Fainelli <florian.fainelli at broadcom.com>
---
 drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index 5045a7e57f1d..e32901a92fcf 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -687,7 +687,7 @@ static int nsp_gpio_probe(struct platform_device *pdev)
 
 	ret = devm_gpiochip_add_data(dev, gc, chip);
 	if (ret < 0) {
-		dev_err(dev, "unable to add GPIO chip\n");
+		dev_err_probe(dev, ret, "unable to add GPIO chip\n");
 		return ret;
 	}
 
-- 
2.34.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230807/5135de0e/attachment.p7s>


More information about the linux-arm-kernel mailing list