[PATCH -next 2/6] ethernet/intel: Remove unnecessary ternary operators

[Jacob Keller]

On 8/3/2023 8:53 PM, Ruan Jinjie wrote:
> Ther are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>
> ---
>  drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
>  drivers/net/ethernet/intel/igc/igc_phy.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
> index a018000f7db9..c123c9dd6a49 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_phy.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
> @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations,
>  			udelay(usec_interval);
>  	}
>  
> -	*success = (i < iterations) ? true : false;
> +	*success = i < iterations;
>  
>  	return ret_val;
>  }
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 53b77c969c85..a553e9d719e7 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -93,7 +93,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
>  			udelay(usec_interval);
>  	}
>  
> -	*success = (i < iterations) ? true : false;
> +	*success = i < iterations;
>  
>  	return ret_val;
>  }

Reviewed-by: Jacob Keller <jacob.e.keller at intel.com>