[PATCH 00/47] fbdev: Use I/O helpers

Thomas Zimmermann tzimmermann at suse.de
Tue Aug 1 01:59:33 PDT 2023


Hi Sam

Am 28.07.23 um 20:39 schrieb Sam Ravnborg:
> Hi Thomas,
> 
> On Fri, Jul 28, 2023 at 06:39:43PM +0200, Thomas Zimmermann wrote:
>> Most fbdev drivers operate on I/O memory. And most of those use the
>> default implementations for file I/O and console drawing. Convert all
>> these low-hanging fruits to the fb_ops initializer macro and Kconfig
>> token for fbdev I/O helpers.
>>
>> The fbdev I/O helpers are easily grep-able. In a later patch, they can
>> be left to empty values if the rsp. funtionality, such as file I/O or
>> console, has been disabled.
> 
> Did you miss sm750 or was it left out on purpose?
> As it hide in staging it is easy to miss.

Now I remembered why I left out sm750fb. It modifies the function 
pointers at some point at

https://elixir.bootlin.com/linux/latest/source/drivers/staging/sm750fb/sm750.c#L741

So the driver uses a non-trivial fb_ops setup and is worth a different fix.

Best regards
Thomas

> 
> 	Sam

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230801/7d10f32d/attachment.sig>


More information about the linux-arm-kernel mailing list