[PATCH] dt-bindings: leds: Drop redundant cpus enum match
Lee Jones
lee at kernel.org
Thu Apr 27 10:17:22 PDT 2023
On Mon, 24 Apr 2023, Nishanth Menon wrote:
> Commit e91a4d5deb96 ("dt-bindings: leds: Document commonly used
> LED triggers") introduced a enum match for cpu, while a pattern
> '^cpu[0-9]*$' already exists.
>
> This causes linux,default-trigger = "cpu" to have more than one match
> and generates the following dtbs_check warning:
>
> arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: leds: led-2:linux,default-trigger: More than one condition true in oneOf schema:
> {'$ref': '/schemas/types.yaml#/definitions/string',
> 'oneOf': [{'items': [{'enum': ['backlight',
> 'default-on',
> 'heartbeat',
> 'disk-activity',
> 'disk-read',
> 'disk-write',
> 'timer',
> 'pattern',
> 'audio-micmute',
> 'audio-mute',
> 'bluetooth-power',
> 'cpu',
> 'flash',
> 'kbd-capslock',
> 'mtd',
> 'nand-disk',
> 'none',
> 'torch',
> 'usb-gadget',
> 'usb-host',
> 'usbport']}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^cpu[0-9]*$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^hci[0-9]+-power$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^mmc[0-9]+$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^phy[0-9]+tx$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'}]}
>
> Drop the explicit match against cpu since the pattern match already
> covers the same.
>
> Fixes: e91a4d5deb96 ("dt-bindings: leds: Document commonly used LED triggers")
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
> Signed-off-by: Nishanth Menon <nm at ti.com>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
More information about the linux-arm-kernel
mailing list