[PATCH] mediatek/clk-mt8173-apmixedsys: convert to devm_platform_ioremap_resource

Hao Ge gehao at kylinos.cn
Thu Apr 20 01:53:08 PDT 2023


On 4/14/23 02:40, Stephen Boyd wrote:
> Quoting Hao Ge (2023-04-13 02:01:28)
>> diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
>> index a56c5845d07a..fe386bf8225d 100644
>> --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
>> +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
>> @@ -90,7 +90,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev)
>>          struct clk_hw *hw;
>>          int r;
>>   
>> -       base = of_iomap(node, 0);
>> +       base = devm_platform_ioremap_resource(pdev, 0);
>>          if (!base)
> 
> This needs to be updated.
> 
>>                  return PTR_ERR(base);
> 
> And PTR_ERR(NULL) is 0, which is wrong.
Thank you for pointing out this point and Sorry for the late reply.
I will update the v2 for it.

Best regards.
Hao



More information about the linux-arm-kernel mailing list