[PATCH] staging: vchiq_arm: Make vchiq_platform_init() static

Stefan Wahren stefan.wahren at i2se.com
Tue Apr 18 23:37:58 PDT 2023


Hi Simon,

Am 18.04.23 um 13:23 schrieb Simon Horman:
> vchiq_platform_init() is only used in this file so it can be static.
> 
> clang-16 with W=1 reports:
> 
>   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes]
>   int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
>       ^
>   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> 
> Signed-off-by: Simon Horman <horms at kernel.org>

this is not the first attempt to fix this [1]. But maybe this has been 
fixed in the meantime.

[1] - 
https://lore.kernel.org/linux-staging/20221022043548.1671644-1-scottjcrouch@gmail.com/#t



More information about the linux-arm-kernel mailing list