[PATCH] soc: mdediatek: devapc: use devm_platform_ioremap_resource() instead of of_iomap()

AngeloGioacchino Del Regno angelogioacchino.delregno at collabora.com
Tue Apr 18 03:09:17 PDT 2023


Il 14/04/23 11:21, zhengkang huang ha scritto:
> In mtk_devapc_probe(), if of_iomap succeeds and any following error occurs,
> it needs to deallocate the resource.
> 
> Fix this by repalcing of_iomap with devm_platform_ioremap_resource, which
> automatically self-manages the resource. This can avoid modifying error
> handling code.
> 
> Signed-off-by: zhengkang huang <zkhuang at hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91 at hust.edu.cn>

You haven't tested this patch on any MediaTek SoC, have you?

This will break devapc.

Regards,
Angelo





More information about the linux-arm-kernel mailing list