[PATCH v2 01/19] arm64/sysreg: Add ID register ID_AA64MMFR3
Joey Gouly
joey.gouly at arm.com
Thu Apr 13 04:25:35 PDT 2023
On Thu, Apr 13, 2023 at 12:14:59PM +0100, Mark Brown wrote:
> On Thu, Apr 13, 2023 at 12:04:55PM +0100, Joey Gouly wrote:
> > Add the new ID register ID_AA64MMFR3.
>
> DDI0601 2023-03 has a few more values which this misses, it looks like
> this might have been done against DDO0601 2022-12? Ideally we'd update
> to the new version but it's not urgent so:
>
> Reviewed-by: Mark Brown <broonie at kernel.org>
>
> It's good to note what version of the architecture you're syncing with.
>
> > +Enum 59:56 ADERR
> > + 0b0000 NI
> > + 0b0001 DEV_ASYNC
> > + 0b0010 FEAT_ADERR
> > +EndEnum
>
> There's also 0b0011 which on a quick scan I'm not sure what a clear name
> for is.
>
> > +Enum 55:52 SDERR
> > + 0b0000 NI
> > + 0b0001 DEV_SYNC
> > + 0b0001 FEAT_SDERR
> > +EndEnum
>
> Similar pattern to ADERR here.
>
> > +Res0 51:48
> > +Enum 47:44 ANERR
> > + 0b0000 ASYNC
> > + 0b0001 FEAT_ANERR
> > +EndEnum
>
> There's also 0b0010 and 0b0011 for this.
>
> > +Enum 43:40 SNERR
> > + 0b0000 SYNC
> > + 0b0001 FEAT_SNERR
> > +EndEnum
>
> Similar pattern to ANERR here.
Yes I was doing this against a 2022-12 version.
I completely messed up this section though, looks like I accidentaly got rid of
all the `0b0000 NI` values. Will redo this part.
Thanks,
Joey
More information about the linux-arm-kernel
mailing list