[PATCH] spi: atmel: Improve exception handling in atmel_spi_configure_dma()

Markus Elfring Markus.Elfring at web.de
Fri Apr 7 08:07:36 PDT 2023


>> The label “error” was used to jump to another pointer check despite of
>> the detail in the implementation of the function “atmel_spi_configure_dma”
>> that it was determined already that the corresponding variable
>> contained an error pointer because of a failed call of
>> the function “dma_request_chan”.
>>
>> * Thus use more appropriate labels instead.
>>
>> * Delete two redundant checks.
>>
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Fixes: 398b6b310ec85eef9d98df5963d5ded18aa92ad8 ("spi: atmel: switch to use modern name")
…
> It's becoming a pattern, but still:
> NACK.

What does hinder you to work with more jump labels for improved exception handling?

Regards,
Markus



More information about the linux-arm-kernel mailing list