[PATCH v2 1/3] dt-bindings: net: add st,stlc45xx

Krzysztof Kozlowski krzk at kernel.org
Fri Apr 7 00:04:29 PDT 2023


On 04/04/2023 10:23, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
> 
> Link: https://lore.kernel.org/all/e8dc9acb-6f85-e0a9-a145-d101ca6da201@gmail.com/
> Acked-by: Christian Lamparter <chunkeey at gmail.com>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---


> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +	#address-cells = <1>;
> +	#size-cells = <0>;

You have here inconsistent indentation - tabs/spaces. Use 4-spaces for
DTS example.

> +
> +	wifi at 0 {
> +	    compatible = "st,stlc4560";
> +	    reg = <0>;
> +	    spi-max-frequency = <48000000>;
> +	    interrupts-extended = <&gpio 23>;
> +	    powerdown-gpios = <&gpio 1>;
> +	};
> +    };

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list