[PATCH 2/5] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC

[Krzysztof Kozlowski]

On 06/04/2023 12:22, Niko Pasaloukos wrote:
> Add device tree bindings for the Blaize BLZP1600 CB2
> development board.
> 
> Co-developed-by: James Cowgill <james.cowgill at blaize.com>
> Signed-off-by: James Cowgill <james.cowgill at blaize.com>
> Co-developed-by: Matt Redfearn <matt.redfearn at blaize.com>
> Signed-off-by: Matt Redfearn <matt.redfearn at blaize.com>
> Co-developed-by: Neil Jones <neil.jones at blaize.com>
> Signed-off-by: Neil Jones <neil.jones at blaize.com>
> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos at blaize.com>
> ---
>  .../devicetree/bindings/arm/blaize.yaml       | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/blaize.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/blaize.yaml b/Documentation/devicetree/bindings/arm/blaize.yaml
> new file mode 100644
> index 000000000000..739115ba1fec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/blaize.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/blaize.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Blaize Platforms Device Tree Bindings

If four of people were working on this, I would expect that at least one
person would point that it's not correct name. Start from recent
bindings. Drop Device Tree Bindings.

> +
> +maintainers:
> +  - James Cowgill <james.cowgill at blaize.com>
> +  - Matt Redfearn <matt.redfearn at blaize.com>
> +  - Neil Jones <neil.jones at blaize.com>
> +  - Nikolaos Pasaloukos <nikolaos.pasaloukos at blaize.com>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: Blaize BLZP1600 based Boards
> +        items:
> +          - enum:
> +              - blaize,blzp1600-som-cb2

som is not a board. You miss board compatible or this is a bit misleading.

Best regards,
Krzysztof