[EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema

[Joy Zou]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: 2022年10月28日 10:01
> To: Joy Zou <joy.zou at nxp.com>; vkoul at kernel.org; robh+dt at kernel.org;
> krzysztof.kozlowski+dt at linaro.org; shawnguo at kernel.org;
> s.hauer at pengutronix.de; kernel at pengutronix.de; festevam at gmail.com
> Cc: S.J. Wang <shengjiu.wang at nxp.com>; martink at posteo.de;
> dev at lynxeye.de; alexander.stein at ew.tq-group.com; Peng Fan
> <peng.fan at nxp.com>; david at ixit.cz; aford173 at gmail.com; Hongxing Zhu
> <hongxing.zhu at nxp.com>; dl-linux-imx <linux-imx at nxp.com>;
> dmaengine at vger.kernel.org; devicetree at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> Subject: Re: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert imx
> sdma to DT schema
> 
> Caution: EXT Email
> 
> On 26/10/2022 23:01, Joy Zou wrote:
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> >> Sent: 2022年10月26日 22:59
> >> To: Joy Zou <joy.zou at nxp.com>; vkoul at kernel.org; robh+dt at kernel.org;
> >> krzysztof.kozlowski+dt at linaro.org; shawnguo at kernel.org;
> >> s.hauer at pengutronix.de; kernel at pengutronix.de; festevam at gmail.com
> >> Cc: S.J. Wang <shengjiu.wang at nxp.com>; martink at posteo.de;
> >> dev at lynxeye.de; alexander.stein at ew.tq-group.com; Peng Fan
> >> <peng.fan at nxp.com>; david at ixit.cz; aford173 at gmail.com; Hongxing Zhu
> >> <hongxing.zhu at nxp.com>; dl-linux-imx <linux-imx at nxp.com>;
> >> dmaengine at vger.kernel.org; devicetree at vger.kernel.org;
> >> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> >> Subject: [EXT] Re: [PATCH v8 1/2] dt-bindings: fsl-imx-sdma: Convert
> >> imx sdma to DT schema
> >>
> >> Caution: EXT Email
> >>
> >> On 25/10/2022 04:36, Joy Zou wrote:
> >>> Convert the i.MX SDMA binding to DT schema format using json-schema.
> >>>
> >>> The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma,
> >>> fsl,imx35-to1-sdma and fsl,imx35-to2-sdma are not used. So need to
> >>> delete it. The compatibles fsl,imx50-sdma, fsl,imx6sll-sdma and
> >>> fsl,imx6sl-sdma are added. The original binding don't list all compatible
> used.
> >>>
> >>> In addition, add new peripheral types HDMI Audio.
> >>>
> >>> Signed-off-by: Joy Zou <joy.zou at nxp.com>
> >>> ---
> >>> Changes in v8:
> >>> add the dma-controller quotes.
> >>
> >> Why adding quotes?
> > I refer to your comments in patch v7/1. The comment as follow:
> > +maintainers:
> > +  - Joy Zou <joy.zou at nxp.com>
> > +
> > You need to reference dma-controller.yaml schema.
> 
> Yes, you need to reference dma-controller.yaml. Nothing about quotes.
> Reference is "$ref: .....yaml"
> 
> 
> > +properties:
> > +  compatible:
> > +    one of:
> > I misunderstand that add the dma-controller.yaml quotes.
> 
> There was nothing about quotes - ".
> 
> > So I am a little confused. Now, I see.
> > should I add dma-common.yaml quotes but not the dma-controller?
> 
> Just drop "
Thank you very much for your comments.
I have changed in patch v9.
BR
Joy Zou
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wiki
> pedia.org%2Fwiki%2FQuotation_mark&data=05%7C01%7Cjoy.zou%40nx
> p.com%7C01a8f1df618e4811dec208dab8884860%7C686ea1d3bc2b4c6fa92c
> d99c5c301635%7C0%7C0%7C638025192713842798%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0%3D%7C3000%7C%7C%7C&sdata=UTq378xCa%2Bi4uj0IKxO1lDHpf
> YnKColWT33OVV0T3zE%3D&reserved=0
> 
> Best regards,
> Krzysztof