REGRESSION in 6.0-rc7 caused by patch "ARM/dma-mapping: use dma-direct unconditionally"

[Klaus Kudielka]

On Thu, 2022-10-20 at 19:22 +0100, Russell King (Oracle) wrote:
> Is it possible that this would also cause data corruption reading from
> a SATA card on armada-38x platforms?
> 
> I'm getting with 6.0:
> 
> [    1.410115] EXT4-fs error (device sda1): htree_dirblock_to_tree:1093:
> inode #256: block 8797: comm systemd: bad entry in directory: rec_len % 4
> != 0 - offset=0, inode=33188, rec_len=35097, size=4096 fake=0
> 
> which appears to be due to reading bad data from the SATA device -
> what this tells me in inode and rec_len is not what is actually on
> the device in question.
> 
> Booting back to 5.19 gives a clean filesystem which has no errors,
> so it isn't filesystem corruption, it is an inability for 6.0 to
> read data correctly from the device.
> 

For reference, I am running 6.0.0, with the following two patches applied
on top:

ARM/dma-mappіng: don't override ->dma_coherent when set from a bus notifier
ARM/dma-mapping: remove the dma_coherent member of struct dev_archdata

Turris Omnia (Armada 385), EXT4 rootfs on a Kingston UV500 mSATA drive.

I have 16 days uptime and am error-free, as far as I can tell. Definitely,
not a single EXT4-fs error.

Regards, Klaus