[PATCH v2 1/3] perf vendor events arm64: Fix incorrect Hisi hip08 L3 metrics

Shang XiaoJing shangxiaojing at huawei.com
Fri Oct 21 03:50:33 PDT 2022


Commit 0cc177cfc95d ("perf vendor events arm64: Add Hisi hip08 L3
metrics") add L3 metrics of hip08, but some metrics (IF_BP_MISP_BR_RET,
IF_BP_MISP_BR_RET, IF_BP_MISP_BR_BL) have incorrect event number due to
the mistakes in document, which caused incorrect result. Fix the
incorrect metrics.

before:
65,811,214,308	armv8_pmuv3_0/event=0x1014/	# 18.87 push_branch
						# -40.19 other_branch
3,564,316,780	BR_MIS_PRED			# 0.51 indirect_branch
						# 21.81 pop_branch

after:
6,537,146,245	BR_MIS_PRED			# 0.48 indirect_branch
						# 0.47 pop_branch
						# 0.00 push_branch
						# 0.05 other_branch

Fixes: 0cc177cfc95d ("perf vendor events arm64: Add Hisi hip08 L3 metrics")
Signed-off-by: Shang XiaoJing <shangxiaojing at huawei.com>
Cc: John Garry <john.garry at huawei.com>
Acked-by: James Clark <james.clark at arm.com>
---
changes in v2:
- adjust commit msg.
---
 .../perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
index 6970203cb247..6443a061e22a 100644
--- a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
+++ b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
@@ -112,21 +112,21 @@
         "MetricName": "indirect_branch"
     },
     {
-        "MetricExpr": "(armv8_pmuv3_0 at event\\=0x1014@ + armv8_pmuv3_0 at event\\=0x1018@) / BR_MIS_PRED",
+        "MetricExpr": "(armv8_pmuv3_0 at event\\=0x1013@ + armv8_pmuv3_0 at event\\=0x1016@) / BR_MIS_PRED",
         "PublicDescription": "Push branch L3 topdown metric",
         "BriefDescription": "Push branch L3 topdown metric",
         "MetricGroup": "TopDownL3",
         "MetricName": "push_branch"
     },
     {
-        "MetricExpr": "armv8_pmuv3_0 at event\\=0x100c@ / BR_MIS_PRED",
+        "MetricExpr": "armv8_pmuv3_0 at event\\=0x100d@ / BR_MIS_PRED",
         "PublicDescription": "Pop branch L3 topdown metric",
         "BriefDescription": "Pop branch L3 topdown metric",
         "MetricGroup": "TopDownL3",
         "MetricName": "pop_branch"
     },
     {
-        "MetricExpr": "(BR_MIS_PRED - armv8_pmuv3_0 at event\\=0x1010@ - armv8_pmuv3_0 at event\\=0x1014@ - armv8_pmuv3_0 at event\\=0x1018@ - armv8_pmuv3_0 at event\\=0x100c@) / BR_MIS_PRED",
+        "MetricExpr": "(BR_MIS_PRED - armv8_pmuv3_0 at event\\=0x1010@ - armv8_pmuv3_0 at event\\=0x1013@ - armv8_pmuv3_0 at event\\=0x1016@ - armv8_pmuv3_0 at event\\=0x100d@) / BR_MIS_PRED",
         "PublicDescription": "Other branch L3 topdown metric",
         "BriefDescription": "Other branch L3 topdown metric",
         "MetricGroup": "TopDownL3",
-- 
2.17.1




More information about the linux-arm-kernel mailing list