[PATCH v4] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Oct 19 06:11:55 PDT 2022


On Wed, Oct 19, 2022 at 05:42:18PM +0800, xinlei.lee at mediatek.com wrote:
> From: xinlei lee <xinlei.lee at mediatek.com>
> 
> In the original mtk_disp_pwm_get_state() function wrongly uses bit 0 of
> CON0 to judge if the PWM is enabled.
> However that is indicated by a bit (at a machine dependent position) in
> the DISP_PWM_EN register. Fix this accordingly.
> 
> Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
> Signed-off-by: xinlei lee <xinlei.lee at mediatek.com>

Nice commit log text :-)

This now matches the bit that the .apply() callback sets, so looks
right.

Reviewed-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20221019/27e06187/attachment.sig>


More information about the linux-arm-kernel mailing list