[PATCH v3] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm

[xinlei.lee]

On Wed, 2022-10-19 at 09:19 +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Sep 29, 2022 at 06:26:49PM +0800, xinlei.lee at mediatek.com
> wrote:
> > From: xinlei lee <xinlei.lee at mediatek.com>
> > 
> > In the original mtk_disp_pwm_get_state() function, the result of
> > reading
> > con0 & BIT(0) is enabled as disp_pwm.
> > In order to conform to the register table, we should use the
> > disp_pwm
> > base address as the enabled judgment.
> 
> I assume the change is fine. However I don't understand the commit
> log.
> My guess is you mean:
> 
> 	mtk_disp_pwm_get_state() wrongly uses bit 0 of CON0 to judge if
> the
> 	PWM is enabled. However that is indicated by a bit (at a
> machine
> 	dependent position) in the DISP_PWM_EN register. Fix this
> 	accordingly.
> 
> > Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API
> > .get_state()")
> > 
> > Signed-off-by: xinlei lee <xinlei.lee at mediatek.com>
> 
> Nitpick: There is no empty line between Fixes: and S-o-b.
> 
> Best regards
> Uwe
> 

Hi Uwe:

Yes, as you describe, I will remove the blank lines you mentioned in
the next version.

Best Regards!
xinlei