[PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

Alexander Stein alexander.stein at ew.tq-group.com
Wed Oct 12 22:55:06 PDT 2022


Hello Damien,

Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal:
> On 10/12/22 22:30, Alexander Stein wrote:
> > Hello Fabio,
> > 
> > Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
> >> Hi Alexander,
> >> 
> >> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
> >> 
> >> <alexander.stein at ew.tq-group.com> wrote:
> >>> 'ahci:' is an invalid prefix, preventing the module from autoloading.
> >>> Fix this by using the 'platform:' prefix and DRV_NAME.
> >> 
> >> What about adding a Fixes tag?
> >> 
> >> Reviewed-by: Fabio Estevam <festevam at gmail.com>
> > 
> > Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at
> > which point auto loading stopped working (if it did at all).
> 
> Given that the alias was wrong in the first place when added for a
> platform driver, this I think should be a fix for:
> 
> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms")

I was hesitating tagging the very first commit, not knowing if it did work at 
that time. But it seems reasonable.

> I can add the Fixes tag when applying.

Thanks!

Best regards,
Alexander





More information about the linux-arm-kernel mailing list