[PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services
Elliot Berman
quic_eberman at quicinc.com
Mon Oct 10 11:06:30 PDT 2022
On 10/3/2022 12:01 AM, Jiri Slaby wrote:
> On 28. 09. 22, 21:56, Elliot Berman wrote:
>> +struct rm_cons_port {
>> + struct tty_port port;
>> + u16 vmid;
>> + bool open;
>> + unsigned int index;
>> +
>> + DECLARE_KFIFO(put_fifo, char, 1024);
>
> Why is tty_port::xmit_fifo not enough?
>
xmit_fifo gave me some inspiration to avoid using KFIFO here and skip
extra an extra memcpy into/out of the FIFO.
I've also dropped out the FIFO usage for tty_operations and this
buffering is only used for printk console.
Thanks,
Elliot
More information about the linux-arm-kernel
mailing list