[PATCH 29/38] arm64/sysreg: Convert ID_PFR0_EL1 to automatic generation

[James Morse]

Hi Will,

On 14/11/2022 15:02, Will Deacon wrote:
> On Fri, Oct 28, 2022 at 06:17:48PM +0100, Mark Brown wrote:
>> On Fri, Oct 28, 2022 at 05:54:17PM +0100, James Morse wrote:
>>
>>> Convert ID_PFR0_EL1 to be automatically generated as per DDI0487I.a,
>>> no functional changes.
>>
>>> +Enum	19:16	CSV2
>>> +	0b0000	IMP
>>> +	0b0001	IMP
>>> +	0b0010	CSV2p1
>>> +EndEnum
>>
>> Should 0b0000 not be something like UNDISCLOSED (DDI0487I.a says "The
>> implementation does not disclose whether FEAT_CSV2 is implemented.")?

Sure,


>> (I'm vaugely surprised the compiler didn't moan about the redefinition
>> of the constant.)
> 
> I'm not fussed about the name, but the duplicate field definitely needs
> fixing otherwise defconfig is really noisy:
> 
> ./arch/arm64/include/generated/asm/sysreg-defs.h:42:9: warning: 'ID_PFR0_EL1_CSV2_IMP' macro redefined [-Wmacro-redefined]
> #define ID_PFR0_EL1_CSV2_IMP                            UL(0b0001)
>         ^
> ./arch/arm64/include/generated/asm/sysreg-defs.h:41:9: note: previous definition is here
> #define ID_PFR0_EL1_CSV2_IMP                            UL(0b0000)
>         ^
> 
> James -- please can you spin a v2 with this fixed?

Yup, sorry. I made some totally trivial change from the RFC - then completely fouled up
the rebase. Conflicts in this file are hilarious.


Thanks,

James