[PATCH v2 0/2] arm64: dts: imx8mp-verdin: Add DSI Bridges

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Nov 29 10:41:25 PST 2022


Hi Francisco,

On Tue, Nov 29, 2022 at 03:44:10PM +0100, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini at toradex.com>
> 
> This series add DSI to HDMI and DSI to LVDS functionality to the Verdin iMX8M
> Plus device tree.
> 
> Previous v1 [1] triggered some discussion with Laurent since these bridges are not
> strictly part of the SoM, but are part of the whole board that is made out of
> SoM + Carrier Board (e.g. Yavia [2]) or SoM + Carrier Board + Adapter
> (e.g. Dahlia [3]). For this reason they are disabled by default.
> 
> I have not addressed his concerns here apart for the explanation I gave him in
> the previous discussion thread, I do still believe that this could be merged as
> it is.

I still think those should not be part of the SoM .dtsi if the
peripherals are not in the SoM. I would model them either as part of the
carrier board, or as overlays, depending on the case. It would be fine
creating a .dtsi that is included by both carrier board .dts and overlay
.dts.

The final decision belongs to the maintainers, I'm only a reviewer :-)

> This series is based on next-20221129.
> 
> Francesco
> 
> [1] https://lore.kernel.org/all/20220905211703.GA6180@francesco-nb.int.toradex.com/
> [2] https://www.toradex.com/products/carrier-board/yavia
> [3] https://www.toradex.com/products/carrier-board/dahlia-carrier-board-kit
> 
> v2: 
>  - Added HDMI hot plug detect GPIO
> 
> Max Krummenacher (2):
>   arm64: dts: imx8mp-verdin: add dsi to hdmi functionality
>   arm64: dts: imx8mp-verdin: add dsi to lvds functionality
> 
>  .../boot/dts/freescale/imx8mp-verdin.dtsi     | 21 ++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)

-- 
Regards,

Laurent Pinchart



More information about the linux-arm-kernel mailing list