[PATCH v1 2/2] arm64/asm: Remove unused assembler DAIF save/restore macros

Mark Rutland mark.rutland at arm.com
Thu Nov 24 02:59:37 PST 2022


On Wed, Nov 23, 2022 at 06:02:09PM +0000, Mark Brown wrote:
> There are no longer any users of the assembler macros for saving and
> restoring DAIF so remove them to prevent further users being added, there
> are C equivalents available.
> 
> Signed-off-by: Mark Brown <broonie at kernel.org>

Getting rid of these will make it easier to clean up DAIF / PMR manipulation
generally, so FWIW:

  Acked-by: Mark Rutland <mark.rutland at arm.com>

Mark.

> ---
>  arch/arm64/include/asm/assembler.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
> index 88175551b401..d8d6627be0f6 100644
> --- a/arch/arm64/include/asm/assembler.h
> +++ b/arch/arm64/include/asm/assembler.h
> @@ -34,11 +34,6 @@
>  	wx\n	.req	w\n
>  	.endr
>  
> -	.macro save_and_disable_daif, flags
> -	mrs	\flags, daif
> -	msr	daifset, #0xf
> -	.endm
> -
>  	.macro disable_daif
>  	msr	daifset, #0xf
>  	.endm
> @@ -47,10 +42,6 @@
>  	msr	daifclr, #0xf
>  	.endm
>  
> -	.macro	restore_daif, flags:req
> -	msr	daif, \flags
> -	.endm
> -
>  /*
>   * Save/restore interrupts.
>   */
> -- 
> 2.30.2
> 



More information about the linux-arm-kernel mailing list