[PATCH] perf: arm_cspmu: Fix build failure on x86_64

Suzuki K Poulose suzuki.poulose at arm.com
Thu Nov 17 01:18:14 PST 2022


On 16/11/2022 19:04, Besar Wicaksono wrote:
> Building on x86_64 allmodconfig failed:
>    | drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit
>    |    declaration of function 'get_acpi_id_for_cpu'
> 
> get_acpi_id_for_cpu is a helper function from ARM64.
> Fix by adding ARM64 dependency.
> 
> Signed-off-by: Besar Wicaksono <bwicaksono at nvidia.com>

nit: Not sure if we have a stable commit id to mark "fixes".
May be that is not needed until it hits upstream.

Reviewed-by: Suzuki K Poulose <suzuki.poulose at arm.com>

> ---
>   drivers/perf/arm_cspmu/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/arm_cspmu/Kconfig b/drivers/perf/arm_cspmu/Kconfig
> index 058223bef661..0b316fe69a45 100644
> --- a/drivers/perf/arm_cspmu/Kconfig
> +++ b/drivers/perf/arm_cspmu/Kconfig
> @@ -4,7 +4,7 @@
>   
>   config ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU
>   	tristate "ARM Coresight Architecture PMU"
> -	depends on ACPI
> +	depends on ARM64 && ACPI
>   	depends on ACPI_APMT || COMPILE_TEST
>   	help
>   	  Provides support for performance monitoring unit (PMU) devices
> 
> base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c




More information about the linux-arm-kernel mailing list