[PATCH v2 2/4] arm64/signal: Include TPIDR2 in the signal context

Will Deacon will at kernel.org
Tue Nov 15 04:22:26 PST 2022


On Tue, Nov 15, 2022 at 12:08:44PM +0000, Mark Brown wrote:
> On Mon, Nov 14, 2022 at 04:10:06PM +0000, Will Deacon wrote:
> > On Mon, Oct 31, 2022 at 08:17:34PM +0000, Mark Brown wrote:
> 
> > > +			if (user->tpidr2)
> > > +				goto invalid;
> 
> > > +			if (size != sizeof(*user->tpidr2))
> 
> > Why are you requiring an exact match here? Won't that hinder any future
> > extension of the structure?
> 
> It will but since the structure is explicitly for a single sysreg
> that's intentional - the thinking was to just continue to model
> any more sysregs we want to report in the signal context in the
> same format with their own contexts.  It felt like it fit better
> into how everything else in the signal context is extended.

I see, but having the usual '<' check wouldn't preclude us from doing
what you suggest above, whilst also giving us some flexibility in case
things turn out differently from how we expected.

Will



More information about the linux-arm-kernel mailing list