[PATCH v15 8/8] arm64: dts: qcom: sm8250: Add tpdm mm/prng

[Krzysztof Kozlowski]

On 14/11/2022 15:40, Mao Jinlong wrote:
> Add tpdm mm and tpdm prng for sm8250.
> 
> +---------------+                +-------------+
> |  tpdm at 6c08000 |                |tpdm at 684C000 |
> +-------|-------+                +------|------+
>         |                               |
> +-------|-------+                       |
> | funnel at 6c0b000|                       |
> +-------|-------+                       |
>         |                               |
> +-------|-------+                       |
> |funnel at 6c2d000 |                       |
> +-------|-------+                       |
>         |                               |
>         |    +---------------+          |
>         +----- tpda at 6004000  -----------+
>              +-------|-------+
>                      |
>              +-------|-------+
>              |funnel at 6005000 |
>              +---------------+
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao at quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 173 +++++++++++++++++++++++++++
>  1 file changed, 173 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 80193bb3c478..0914b4b9c862 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2746,6 +2746,76 @@
>  			};
>  		};
>  
> +		tpda at 6004000 {
> +			compatible = "arm,primecell";

Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).

I don't think your bindings allow this to be alone...

Beside, your patch does not apply. Is it based on Bjorn's tree?

> +			reg = <0 0x06004000 0 0x1000>;
> +			reg-names = "tpda-base";
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port at 0 {
> +					reg = <0>;
> +					tpda_out_funnel_qatb: endpoint {
> +						remote-endpoint = <&funnel_qatb_in_tpda>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port at 9 {
> +					reg = <9>;
> +					tpda_9_in_tpdm_mm: endpoint {
> +						remote-endpoint = <&tpdm_mm_out_tpda9>;
> +					};
> +				};
> +
> +				port at 17 {
> +					reg = <23>;
> +					tpda_23_in_tpdm_prng: endpoint {
> +						remote-endpoint = <&tpdm_prng_out_tpda_23>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel at 6005000 {
> +			compatible = "arm,primecell";

Same problem, I guess.


Best regards,
Krzysztof