[PATCH v4 8/8] arm64/fp: Use a struct to pass data to fpsimd_bind_state_to_cpu()

Catalin Marinas catalin.marinas at arm.com
Mon Nov 14 02:33:34 PST 2022


On Sat, Oct 22, 2022 at 12:03:21AM +0100, Mark Brown wrote:
> For reasons that are unclear to this reader fpsimd_bind_state_to_cpu()
> populates the struct fpsimd_last_state_struct that it uses to store the
> active floating point state for KVM guests by passing an argument for
> each member of the structure. As the richness of the architecture increases
> this is resulting in a function with a rather large number of arguments
> which isn't ideal.
> 
> Simplify the interface by using the struct directly as the single argument
> for the function, renaming it as we lift the definition into the header.
> This could be built on further to reduce the work we do adding storage for
> new FP state in various places but for now it just simplifies this one
> interface.
> 
> Signed-off-by: Mark Brown <broonie at kernel.org>

I think this looks cleaner.

Reviewed-by: Catalin Marinas <catalin.marinas at arm.com>



More information about the linux-arm-kernel mailing list