[Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7 hardware for Exynos 3250 SoC

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Mon Nov 14 02:05:20 PST 2022


On 14/11/2022 10:44, Aakarsh Jain wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski at linaro.org]
>> Sent: 14 November 2022 13:22
>> To: Aakarsh Jain <aakarsh.jain at samsung.com>; linux-arm-
>> kernel at lists.infradead.org; linux-media at vger.kernel.org; linux-
>> kernel at vger.kernel.org; devicetree at vger.kernel.org
>> Cc: m.szyprowski at samsung.com; andrzej.hajda at intel.com;
>> mchehab at kernel.org; hverkuil-cisco at xs4all.nl;
>> ezequiel at vanguardiasur.com.ar; jernej.skrabec at gmail.com;
>> benjamin.gaignard at collabora.com; krzysztof.kozlowski+dt at linaro.org;
>> stanimir.varbanov at linaro.org; dillon.minfei at gmail.com;
>> david.plowman at raspberrypi.com; mark.rutland at arm.com;
>> robh+dt at kernel.org; krzk+dt at kernel.org; andi at etezian.org;
>> alim.akhtar at samsung.com; aswani.reddy at samsung.com;
>> pankaj.dubey at samsung.com; smitha.t at samsung.com
>> Subject: Re: [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7
>> hardware for Exynos 3250 SoC
>>
>> On 14/11/2022 06:46, Aakarsh Jain wrote:
>>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for
>>
>> Please run scripts/checkpatch.pl and fix reported warnings.
>>
> Do you mean warnings on "5441e9dafdfc6dc40fa" commit? Or on this patch?
>  
> I am running like this :  ./scripts/checkpatch.pl patch_file, it does not show any warnings.
> 
> or am I missing anything while running checkpatch on the current patch?

Eh, you're right... checkpatch does not catch it. You need to fix syntax
- drop quotes, use proper commit title:

https://elixir.bootlin.com/linux/v5.19-rc1/source/Documentation/process/submitting-patches.rst#L100

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list