[PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags

Jagan Teki jagan at amarulasolutions.com
Fri Nov 11 00:49:17 PST 2022


On Fri, Nov 11, 2022 at 6:19 AM Nicolas Boichat <drinkcat at chromium.org> wrote:
>
> On Fri, Nov 11, 2022 at 2:40 AM Jagan Teki <jagan at amarulasolutions.com> wrote:
> >
> > HFP/HBP/HSA/EOT_PACKET modes in Exynos DSI host specifies
> > 0 = Enable and 1 = Disable.
>
> Oh I see, that's confusing... IMHO you might want to change the
> register macro name... (but if that's what the datasheet uses, it
> might not be ideal either). At the _very_ least, I'd add a comment in
> the code so the next person doesn't attempt to "fix" it again...

02/14 on the same series doing the name change.
https://lore.kernel.org/all/20221110183853.3678209-3-jagan@amarulasolutions.com/

>
> BTW, are you sure DSIM_HSE_MODE is correct now?

Yes, we have tested in imx8m platforms as well. Sébastien Szymanski
initially observed this issue on the imx8m platform.

Jagan.



More information about the linux-arm-kernel mailing list