[PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()

Mukesh Ojha quic_mojha at quicinc.com
Thu Nov 10 03:54:29 PST 2022


Hi,

On 11/10/2022 2:56 PM, ye.xingchen at zte.com.cn wrote:
> From: Minghao Chi <chi.minghao at zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao at zte.com.cn>
> ---
>   drivers/dma/bcm2835-dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> 
>   	dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(base))
>   		return PTR_ERR(base);
> 

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha at quicinc.com>


-Mukesh



More information about the linux-arm-kernel mailing list