[Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC.

[Krzysztof Kozlowski]

On 09/11/2022 15:44, Aakarsh Jain wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski at linaro.org]
>> Sent: 09 November 2022 14:31
>> To: Aakarsh Jain <aakarsh.jain at samsung.com>; linux-arm-
>> kernel at lists.infradead.org; linux-media at vger.kernel.org; linux-
>> kernel at vger.kernel.org; devicetree at vger.kernel.org
>> Cc: m.szyprowski at samsung.com; andrzej.hajda at intel.com;
>> mchehab at kernel.org; hverkuil-cisco at xs4all.nl;
>> ezequiel at vanguardiasur.com.ar; jernej.skrabec at gmail.com;
>> benjamin.gaignard at collabora.com; krzysztof.kozlowski+dt at linaro.org;
>> stanimir.varbanov at linaro.org; dillon.minfei at gmail.com;
>> david.plowman at raspberrypi.com; mark.rutland at arm.com;
>> robh+dt at kernel.org; krzk+dt at kernel.org; andi at etezian.org;
>> alim.akhtar at samsung.com; aswani.reddy at samsung.com;
>> pankaj.dubey at samsung.com; smitha.t at samsung.com
>> Subject: Re: [Patch v2 1/3] arm: exynos: Add new compatible string for
>> Exynos3250 SoC.
>>
>> On 09/11/2022 04:55, Aakarsh Jain wrote:
>>> Since,MFC v7 support was added for Exynos5420 and Exynos
>>> 3250 SoC with same compatible string "samsung,mfc-v7".As both SoCs
>>> having different hardware properties and having same compatible string
>>> for both SoCs doesn't seems to be correct.
>>> New compatible is added for Exynos3250 SOC which will differentiate
>>> the node properties for both SoCs which support MFC v7.
>>>
>>> Reviewed-by: Tommaso Merciai
>> <tommaso.merciai at amarulasolutions.com>
>>> Suggested-by: Alim Akhtar <alim.akhtar at samsung.com>
>>> Signed-off-by: Aakarsh Jain <aakarsh.jain at samsung.com>
>>> ---
>>>  Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
>>
>> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>>
> As with recent commits on Documentation/devicetree/bindings/media/s5p-mfc.txt with git log --oneline --  ,  subject prefix doesn't seems to be consistent.
> 
> b1394dc151cb media: s5p-mfc: Adding initial support for MFC v10.10
> 60641e22599a [media] s5p-mfc: Use preallocated block allocator always for MFC v6+
> 003611334d55 [media] s5p-mfc: Add support for MFC v8 available in Exynos 5433 SoCs
> 0da658704136 ARM: dts: convert to generic power domain bindings for exynos DT
> 77634289286a ARM: dts: Update clocks entry in MFC binding documentation
> 2eae613b95a7 ARM: EXYNOS: Add MFC device tree support

s5p-mfc is not a subsystem.

git log --oneline  -- Documentation/devicetree/bindings/media/

media: dt-bindings: NAME_OF_FILE:


> 
> Closest is ARM: dts.

This is not ARM subsystem and not a DTS file.

> so what is your suggestion on this?
> 
> Anyway we are in a process of converting this txt file to yaml . 
> 

Best regards,
Krzysztof