[PATCH] iommu/arm-smmu-v3: Restore prints in arm_smmu_attach_dev()

Nicolin Chen nicolinc at nvidia.com
Wed Nov 9 10:47:35 PST 2022


On Wed, Nov 09, 2022 at 09:11:53AM -0400, Jason Gunthorpe wrote:
> On Tue, Nov 08, 2022 at 11:07:13PM -0800, Nicolin Chen wrote:
> > The prints for incompatible failures in arm_smmu_attach_dev() might be
> > still useful for error diagnosis. As VFIO and IOMMUFD would do testing
> > attach() call, having previous dev_err() isn't ideal either.
> > 
> > Add the prints back using dev_dbg().
> > 
> > Suggested-by: Will Deacon <will at kernel.org>
> > Signed-off-by: Nicolin Chen <nicolinc at nvidia.com>
> > ---
> >  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> You should probably include a fixes line
> 
> Reviewed-by: Jason Gunthorpe <jgg at nvidia.com>

Just sent a v2 adding "Fixes" and "Reviewed-by". Thanks!



More information about the linux-arm-kernel mailing list