[PATCH v2 2/6] dt-bindings: can: mcan: Add ECC functionality to message ram
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Wed Nov 9 03:11:00 PST 2022
On 09/11/2022 11:09, Vivek Yadav wrote:
> Whenever the data is transferred or stored on message ram, there are
> inherent risks of it being lost or corruption known as single-bit errors.
>
> ECC constantly scans data as it is processed to the message ram, using a
> method known as parity checking and raise the error signals for corruption.
>
> Add error correction code config property to enable/disable the
> error correction code (ECC) functionality for Message RAM used to create
> valid ECC checksums.
>
> Signed-off-by: Chandrasekar R <rcsekar at samsung.com>
> Cc: devicetree at vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>
> Cc: Rob Herring <robh+dt at kernel.org>
> Signed-off-by: Vivek Yadav <vivek.2311 at samsung.com>
> ---
> .../bindings/net/can/bosch,m_can.yaml | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index 26aa0830eea1..91dc458ec33f 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -50,6 +50,12 @@ properties:
> - const: hclk
> - const: cclk
>
> + tesla,mram-ecc-cfg:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + Handle to system control region that contains the ECC INIT register
> + and register offset to the ECC INIT register.
That's not way to describe syscon phandle. Property name is ok. For the
rest look at:
https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml#L42
Anyway, this looks like SoC-specific hack, so it does not really fit to
the driver. You have to think of something generic.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list