[PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Tue Nov 8 12:55:58 PST 2022
On 08/11/2022 17:33, Russell King (Oracle) wrote:
> Add a DT binding for the Apple Mac System Management Controller.
Drop the second, redundant "binding" from subject. It's already in prefix.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
> .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml
> new file mode 100644
> index 000000000000..014eba5a1bbc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple Mac System Management Controller
> +
> +maintainers:
> + - Hector Martin <marcan at marcan.st>
> +
> +description:
> + Apple Mac System Management Controller implements various functions
> + such as GPIO, RTC, power, reboot.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,t6000-smc
> + - apple,t8103-smc
> + - apple,t8112-smc
> + - const: apple,smc
> +
> + reg:
> + items:
> + - description: SMC area
> + - description: SRAM area
> +
> + reg-names:
> + items:
> + - const: smc
> + - const: sram
> +
> + mboxes:
> + maxItems: 1
> +
> + gpio:
> + $ref: /schemas/gpio/gpio-macsmc.yaml
So this depends on other patch, so:
1. You need mention the dependency in cover letter (nothing there),
2. Re-order patches.
The GPIO cannot go separate tree and this must be explicitly communicated.
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - mboxes
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + smc at 23e400000 {
Usually these are called system-controller, to have a generic name (as
asked by DT spec).
> + compatible = "apple,t8103-smc", "apple,smc";
> + reg = <0x2 0x3e400000 0x0 0x4000>,
> + <0x2 0x3fe00000 0x0 0x100000>;
Align the items (opening <).
With three above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list