[PATCH v2 5/5] arm64: dts: uniphier: Add NX1 SoC and boards support
Kunihiko Hayashi
hayashi.kunihiko at socionext.com
Tue Nov 8 06:30:24 PST 2022
Hi Krzysztof,
On 2022/11/08 20:13, Krzysztof Kozlowski wrote:
> On 07/11/2022 11:34, Kunihiko Hayashi wrote:
>> Initial version of devicetree sources for NX1 SoC and boards.
>>
>> NX1 SoC belongs to the UniPhier armv8 architecture platform, and is
>> designed for IoT and AI/ML application fields.
>>
>
>> +
>> + soc_glue: syscon at 1f800000 {
>> + compatible = "socionext,uniphier-nx1-soc-glue",
>> + "simple-mfd", "syscon";
>> + reg = <0x1f800000 0x2000>;
>> +
>> + pinctrl: pinctrl {
>> + compatible = "socionext,uniphier-nx1-pinctrl";
>
> So instead of documenting the hardware precisily, you have one big bag
> for everything under simple-mfd. This is not how the SoC should be
> described in DTS.
Sorry I don't understand. This is inherited from the previous descriptions,
but is there some example to express DTS correctly about that?
>
>> + };
>> + };
>> +
>> + soc-glue at 1f900000 {
>> + compatible = "simple-mfd";
>
> No, it is not allowed on its own. You need a specific compatible and
> bindings describing its children.
I saw the definition of "simple-mfd" itself is only in mfd/mfd.txt.
Currently there are only efuse devices as children, and this space means
nothing. I think it had better define the devices directly.
Thank you,
---
Best Regards
Kunihiko Hayashi
More information about the linux-arm-kernel
mailing list