[PATCH 08/26] drm: atmel-hlcdc: Remove #ifdef guards for PM related functions

Sam Ravnborg sam at ravnborg.org
Mon Nov 7 09:53:25 PST 2022


On Mon, Nov 07, 2022 at 05:50:48PM +0000, Paul Cercueil wrote:
> Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle
> the .suspend/.resume callbacks.
> 
> These macros allow the suspend and resume functions to be automatically
> dropped by the compiler when CONFIG_SUSPEND is disabled, without having
> to use #ifdef guards.
> 
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
> 
> Signed-off-by: Paul Cercueil <paul at crapouillou.net>
> ---
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Boris Brezillon <bbrezillon at kernel.org>
> Cc: Nicolas Ferre <nicolas.ferre at microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni at bootlin.com>
> Cc: Claudiu Beznea <claudiu.beznea at microchip.com>
> Cc: linux-arm-kernel at lists.infradead.org
Acked-by: Sam Ravnborg <sam at ravnborg.org>

Thanks for taking care of this.

	Sam




More information about the linux-arm-kernel mailing list