[PATCH v2] arm64: cpufeature: Fix the visibility of compat hwcaps
Amit Kachhap
amit.kachhap at arm.com
Thu Nov 3 01:25:04 PDT 2022
On 11/2/22 16:17, Suzuki K Poulose wrote:
> Hi Amit
>
> On 02/11/2022 10:21, Amit Daniel Kachhap wrote:
>> Commit 237405ebef58 ("arm64: cpufeature: Force HWCAP to be based on the
>> sysreg visible to user-space") forced the hwcaps to use sanitised
>> user-space view of the id registers. However, the ID register structures
>> used to select few compat cpufeatures (vfp, crc32, ...) are masked and
>> hence such hwcaps do not appear in /proc/cpuinfo anymore for PER_LINUX32
>> personality.
>>
>> Add the ID register structures explicitly and set the relevant entry as
>> visible for compat hwcaps.
>>
>> While at it, update the comment for structure ftr_generic_32bits[] which
>> lists the ID register that use it.
>>
>
> Minor nit: With this change, we expose mvfr*_el1 and the following
> document needs an update to reflect the change.
>
> Documentation/arm64/cpu-feature-registers.rst
I just send the v3 with your suggestion. I missed changing the mrs
instruction emulation for crm argument in v2 which I did now.
>
> Otherwise, looks good to me.
Thanks for your feedback.
Amit
>
> Suzuki
>
More information about the linux-arm-kernel
mailing list