[PATCH v2 2/4] pwm: Add Apple PWM controller

Biju Das biju.das.jz at bp.renesas.com
Wed Nov 2 09:43:28 PDT 2022


> Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller
> 
> On Wed, 2 Nov 2022 at 19:29, Biju Das <biju.das.jz at bp.renesas.com>
> wrote:
> >
> > Then enable the clk whenever pwm is enabled And disable the clk
> > whenever pwm is disabled.
> I can do that, but I do not see the point in doing that. This clock is
> active whenever the system is turned on, all this will result in is
> some unnecessary clock refcount increments/decrements.

OK for me, as I do not know about your system. I just pointed out 
you are unnecessarily turning on the clock during probe
even if the pwm is not used.

Cheers,
Biju


More information about the linux-arm-kernel mailing list