[PATCH v6 13/21] gunyah: vm_mgr: Introduce basic VM Manager

Greg Kroah-Hartman gregkh at linuxfoundation.org
Tue Nov 1 22:14:10 PDT 2022


On Wed, Oct 26, 2022 at 11:58:38AM -0700, Elliot Berman wrote:
> +#define GH_CREATE_VM			_IO(GH_IOCTL_TYPE, 0x40) /* Returns a Gunyah VM fd */

Why 0x40?  Why not just use the same KVM ioctl numbers and names as you
are doing the same thing as them, right?

Normally your first ioctl is "0x01", not "0x40", so this feels really
odd.

thanks,

greg k-h



More information about the linux-arm-kernel mailing list