[PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Tom Fitzhenry
tom at tom-fitzhenry.me.uk
Sat May 28 20:45:52 PDT 2022
I've sent this DT for early feedback. I've commented below on the parts
I'm unsure about, and would appreciate any feedback.
On 29/5/22 13:17, Tom Fitzhenry wrote:
> + cluster1_opp_ppp: opp-table1b {
I don't know which OPP should be used.
Per
https://gitlab.com/pine64-org/linux/-/merge_requests/36/diffs?commit_id=dcf78ea8ad6f0b1c6e3279d8d752ca68d6d05756,
using the regular RK3399 OPP table exceeds operating conditions.
Perhaps this should depend on an OPP for RK3399-T (which would need to
be added, as the linked merge request proposes).
> + // Per "TYPE-C", page 23.
> + fusb0: typec-portc at 22 {
> + compatible = "fcs,fusb302";
> + reg = <0x22>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&fusb0_int>;
> + vbus-supply = <&vcc5v0_typec>;
This is the node many PinePhone Pro users have been using for >1 month,
but I don't understand the USB subsystem well enough yet to understand
the node.
More information about the linux-arm-kernel
mailing list