[EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data

[Nicolas Dufresne]

Le vendredi 27 mai 2022 à 11:33 +0000, Ming Qian a écrit :
> > From: Fabio Estevam <festevam at gmail.com>
> > Sent: 2022年5月27日 19:12
> > To: Ming Qian <ming.qian at nxp.com>
> > Cc: Mauro Carvalho Chehab <mchehab at kernel.org>; Mirela Rabulea (OSS)
> > <mirela.rabulea at oss.nxp.com>; Hans Verkuil <hverkuil-cisco at xs4all.nl>;
> > Shawn Guo <shawnguo at kernel.org>; Sascha Hauer <s.hauer at pengutronix.de>;
> > Sascha Hauer <kernel at pengutronix.de>; dl-linux-imx <linux-imx at nxp.com>;
> > linux-media <linux-media at vger.kernel.org>; linux-kernel
> > <linux-kernel at vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED
> > DEVICE TREE BINDINGS <devicetree at vger.kernel.org>; moderated
> > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > <linux-arm-kernel at lists.infradead.org>
> > Subject: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before
> > the
> > configuration data
> > 
> > Caution: EXT Email
> > 
> > Hi Ming,
> > 
> > On Fri, May 27, 2022 at 7:25 AM Ming Qian <ming.qian at nxp.com> wrote:
> > > 
> > > There is a hardware bug that it will load the first 128 bytes of
> > > configuration data twice, it will led to some configure error.
> > > so shift the configuration data 128 bytes, and make the first 128
> > > bytes all zero, then hardware will load the 128 zero twice, and ignore
> > > them as garbage.
> > > then the configuration data can be loaded correctly
> > > 
> > > Signed-off-by: Ming Qian <ming.qian at nxp.com>
> > > Reviewed-by: Mirela Rabulea <mirela.rabulea at nxp.com>
> > > Reviewed-by: Tommaso Merciai <tommaso.merciai at amarulasolutions.com>
> > 
> > Fixes tag?
> 
> Hi Fabio,
>     It's a hardware issue, so I'm not sure is it a driver issue that I fix it.
>     Or I just check which patch includes the code I changed, and add the fix
> tag?

You can use Fixes tag even though there was no software bug. The point of the
tag is to help locate how far we can backport this patch in order to let stable
kernel users benefit.

regards,
Nicolas

> 
> Ming