[PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock

[Stephen Boyd]

Quoting Tomer Maimon (2022-05-22 08:50:34)
> diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> new file mode 100644
> index 000000000000..f305c7c7eaf0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> @@ -0,0 +1,68 @@
[...]
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#clock-cells"

Are clocks not required because sometimes the reference clk isn't
connected?

> +
> +additionalProperties: false
> +
> +examples:
> +  # Clock Control Module node:
> +  - |
> +
> +    ahb {

drop ahb node please.

> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        clk: clock-controller at f0801000 {

Drop label 'clk' as well please.

> +            compatible = "nuvoton,npcm845-clk";
> +            reg = <0x0 0xf0801000 0x0 0x1000>;
> +            #clock-cells = <1>;
> +        };
> +    };
> +
> +...