[PATCH v8 8/9] crypto: arm64/polyval: Add PMULL accelerated implementation of POLYVAL

Herbert Xu herbert at gondor.apana.org.au
Thu May 19 22:53:43 PDT 2022


On Tue, May 10, 2022 at 05:23:58PM +0000, Nathan Huckleberry wrote:
>
> +module_cpu_feature_match(PMULL, polyval_ce_mod_init)
> +
> +module_init(polyval_ce_mod_init);

I get a cross-compile failure on this:

In file included from ../arch/arm64/crypto/polyval-ce-glue.c:25:
../include/linux/module.h:131:42: error: redefinition of ‘__inittest’
  131 |  static inline initcall_t __maybe_unused __inittest(void)  \
      |                                          ^~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:187:1: note: in expansion of macro ‘module_init’
  187 | module_init(polyval_ce_mod_init);
      | ^~~~~~~~~~~
../include/linux/module.h:131:42: note: previous definition of ‘__inittest’ was here
  131 |  static inline initcall_t __maybe_unused __inittest(void)  \
      |                                          ^~~~~~~~~~
../include/linux/cpufeature.h:55:1: note: in expansion of macro ‘module_init’
   55 | module_init(cpu_feature_match_ ## x ## _init)
      | ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:185:1: note: in expansion of macro ‘module_cpu_feature_match’
  185 | module_cpu_feature_match(PMULL, polyval_ce_mod_init)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/module.h:133:6: error: redefinition of ‘init_module’
  133 |  int init_module(void) __copy(initfn)   \
      |      ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:187:1: note: in expansion of macro ‘module_init’
  187 | module_init(polyval_ce_mod_init);
      | ^~~~~~~~~~~
../include/linux/module.h:133:6: note: previous definition of ‘init_module’ was here
  133 |  int init_module(void) __copy(initfn)   \
      |      ^~~~~~~~~~~
../include/linux/cpufeature.h:55:1: note: in expansion of macro ‘module_init’
   55 | module_init(cpu_feature_match_ ## x ## _init)
      | ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:185:1: note: in expansion of macro ‘module_cpu_feature_match’
  185 | module_cpu_feature_match(PMULL, polyval_ce_mod_init)
      | ^~~~~~~~~~~~~~~~~~~~~~~~

Thanks,
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the linux-arm-kernel mailing list