[PATCHv2 1/6] thermal: exynos: Enable core tmu hardware clk flag on exynos platform
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Sun May 15 02:52:30 PDT 2022
On 15/05/2022 08:41, Anand Moon wrote:
> Use clk_prepare_enable api to enable tmu internal hardware clock
> flag on, use clk_disable_unprepare to disable the clock.
>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier at gmail.com>
> Signed-off-by: Anand Moon <linux.amoon at gmail.com>
Here as well you ignored my first comment:
https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@mail.gmail.com/T/#mbfc57b40a7ed043dd4d4890bedb6bad8240058cd
"This is not valid reason to do a change. What is clk_summary does not
really matter. Your change has negative impact on power consumption as
the clock stays enabled all the time. This is not what we want... so
please explain it more - why you need the clock to be enabled all the
time? What is broken (clk_summary is not broken in this case)?"
This was not addressed, you just resent same code...
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list