[PATCH v1 0/7] drm/bridge_connector: perform HPD enablement automatically
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Thu May 12 04:41:56 PDT 2022
On 29/04/2022 21:51, Dmitry Baryshkov wrote:
> From all the drivers using drm_bridge_connector only iMX/dcss and OMAP
> DRM driver do a proper work of calling
> drm_bridge_connector_en/disable_hpd() in right places. Rather than
> teaching each and every driver how to properly handle
> drm_bridge_connector's HPD, make that automatic.
>
> Add two additional drm_connector helper funcs: enable_hpd() and
> disable_hpd(). Make drm_kms_helper_poll_* functions call them (as this
> is the time where the drm_bridge_connector's functions are called by the
> drivers too).
Gracious ping regarding this series. It went for two weeks w/o review.
Few additional points 'pro':
- It makes it possible to handle hpd enablement in cases where the
driver uses a mixture of drm_bridge_connector and old connectors (msm)
- It makes it possible for other connectors to also implement dynamic
hpd enablement/disablement in a standard way
>
> Dmitry Baryshkov (7):
> drm/poll-helper: merge drm_kms_helper_poll_disable() and _fini()
> drm/probe-helper: enable and disable HPD on connectors
> drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement
> drm/imx/dcss: stop using drm_bridge_connector_en/disable_hpd()
> drm/msm/hdmi: stop using drm_bridge_connector_en/disable_hpd()
> drm/omap: stop using drm_bridge_connector_en/disable_hpd()
> drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd()
>
> drivers/gpu/drm/drm_bridge_connector.c | 23 +++----------
> drivers/gpu/drm/drm_probe_helper.c | 40 ++++++++++++++++++-----
> drivers/gpu/drm/imx/dcss/dcss-dev.c | 4 ---
> drivers/gpu/drm/imx/dcss/dcss-kms.c | 4 ---
> drivers/gpu/drm/msm/hdmi/hdmi.c | 2 --
> drivers/gpu/drm/omapdrm/omap_drv.c | 41 ------------------------
> include/drm/drm_bridge_connector.h | 2 --
> include/drm/drm_modeset_helper_vtables.h | 22 +++++++++++++
> 8 files changed, 58 insertions(+), 80 deletions(-)
>
--
With best wishes
Dmitry
More information about the linux-arm-kernel
mailing list